Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: (IAC-1344) (IAC-1363) Add support for K8s 1.29 #538

Merged
merged 2 commits into from
Apr 8, 2024
Merged

feat: (IAC-1344) (IAC-1363) Add support for K8s 1.29 #538

merged 2 commits into from
Apr 8, 2024
+6 −30

Conversation

riragh
Copy link
Member

@riragh riragh commented Mar 28, 2024 •
edited
Loading

Changes:

This PR updates the default versions of ingress-nginx, cluster-autoscaler and kubectl to add support for K8s 1.29

  • Default ingress-nginx chart version is updated to 4.9.1
  • Default cluster-autoscaler chart version is updated to 9.36.0
  • Default kubectl version is updated to 1.28.7

Code to set default version of CLUSTER_AUTOSCALER_CHART_VERSION was simplified as K8s v1.24 is now out standard support for all the cloud providers. For users using K8s v1.24 to do LTS cadence version will now have to specify the CLUSTER_AUTOSCALER_CHART_VERSION in their ansible-var.yaml file. CONFIG_VARS.md file note is updated to guide user about the same.

Tests:

Verified following scenarios, see internal ticket for details.

Scenario Task Provider Cadence kubernetes_version Deploy method Notes
1 OOTB Azure fast:2020 1.27 docker, DO: false
2 OOTB Azure fast:2020 1.28 docker, DO: false New default kubectl
3 OOTB Azure fast:2020 1.29 ansible, DO: true Overwrite kubectl version in the DO
4 OOTB AWS fast:2020 1.29 ansible, DO: true Overwrite kubectl version in the DO

@riragh
feat: (IAC-1344) Updated ingress-nginx default to v1.9.6
0e5927d 
feat: (IAC-1363) Updated cluster-autoscaler default to 9.36.0 and updated kubectl default to add support for K8s 1.29
@riragh riragh added the enhancement New feature or request label Mar 28, 2024
@riragh riragh self-assigned this Mar 28, 2024
@riragh riragh marked this pull request as ready for review April 8, 2024 16:17
dhoucgitter
dhoucgitter approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@dhoucgitter dhoucgitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riragh riragh merged commit 50d6da8 into staging Apr 8, 2024
3 checks passed
@riragh riragh deleted the IAC-1344-1363 branch April 8, 2024 19:31
@riragh riragh mentioned this pull request Apr 10, 2024
Closed
1 task
@riragh riragh mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarpat jarpat jarpat approved these changes

@thpang thpang thpang approved these changes

@dhoucgitter dhoucgitter dhoucgitter approved these changes

@sayeun sayeun Awaiting requested review from sayeun

Assignees

@riragh riragh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@riragh @dhoucgitter @thpang @jarpat